Printable View
Hii, here's a place for me to dump all my scripts.
Basic event /start script
PHP Code://Coded by iMask
function onPlayerChats () {
if (clientr.staff == 1 && this.chat == "/start") { //checks to see if the player is a staff member and sees if you said /start
for (pl : allplayers) { //for all players excluding staff
pl.x=30; //x corrdinate
pl.y=30; //y coorinate
}
}
}
Well then. Hope to see more stuff.
Welp.
Make the NPC move on the x axis
I didn't test this code, so I have no idea if this actually works.PHP Code://Coded by iMask
function onPlayerEnters () {
for (this.n=5;this.n<30;this.n++) {
this.x=this.n;
sleep (0.1);
this.chat = "I am now on "@this.n@" of the x coordinate of this level!";
}
}
It errors with missing semicolon at line 6: this.chat = "I am now on "this.n" of the x coordinate of this level!";Quote:
Originally Posted by iMask
You are correct. It should be:Quote:
Originally Posted by Greg2013
this.chat = "I am now on @this.n@ of the x coordinate of this level!";
that is one messy script xx
- - - Updated - - -
http://codebeautify.org/
http://www.fp4.ca/gs2beautifier/Quote:
Originally Posted by Myst
Scripting is confusing my mind.
What's the point of posting a script if you have not tested it? Also, put your code between PHP quotes so it's easier to read.
This is a good script if you just started scripting, but It's gotta get better :). Good job though despite the errors.
Timer Script (haven't tested this yet)
Can someone please confirm if I'm on the right track?PHP Code://Coded by iMask
function onPlayerChats () {
for (this.i=0;this.chat=="/timer";this.i++) {
this.chat = this.i;
sleep (1);
}
if (this.chat == "/stoptimer") {
break;
this.chat = @"this.i"@;
}
}
PHP Code:function onPlayerChats() {
if (player.chat == "/timer") {
onTimeOut();
} else if (player.chat == "/stoptimer") {
this.chat = this.i;
this.i = 0;
setTimer(0);
}
}
function onTimeOut() {
this.i ++;
this.chat = this.i;
setTimer(1);
}
/Start Topic
/End Topic
Mouse Click warp (haven't tested this yet)
Again, can someone confirm this is correct?PHP Code://Coded by iMask
//#CLIENTSIDE
function onKeyPressed () {
if (this.key == "1") {
this.warp = true;
} else {
this.warp = false;
}
}
}
function onLeftMouseClick () {
if (this.warp == "true") {
player.x = mousex;
player.y = mousey;
}
}
Why bother creating and posting a script, if you don't test it first? Test and post it if it does not work.
Event Door script
PHP Code://Coded by iMask
//#CLIENTSIDE
function onCreated () {
setimg ("door.png");
setshape (0,32,32);
}
function onPlayerChats () {
if (player.chat == "/open" && clientr.staff == 1) {
show();
}
if (player.chat == "/close" && clientr.staff == 1) {
hide();
}
}
Try using Boolean too, alongside else if statements.Quote:
Originally Posted by iMask
The ".png" is actually in the image name :PQuote:
Originally Posted by iMask
That would be: setimg("door.png");
Also, even though it works, but it's preferable to use Gs2 over Gs1: show; becomes this.show(); and hide; becomes this.hide();
Code://#CLIENTSIDE
function onCreated() {
this.image = "door.png";
}
function onPlayerChats() {
if (clientr.isStaff == false) return;
if (player.chat == "/open")
this.show();
else if (player.chat == "/close")
this.hide();
}
Sorry, how would I do that?Quote:
Originally Posted by Grief Hero
Didn't know that! :PQuote:
Originally Posted by John
Thanks John and Alpho
I think Grief means something like the following:
Check out the booleans (the = true and = false), and practice them they are important in the future.PHP Code://MADE BY IMASK
//REVISED BY NOOF*
//#CLIENTSIDE //TIP ALWAYS CHECK THIS TO MAKE SURE IT IS SPELLED CORRECTLY!!
function onCreated() {
this.image = "door.png";
this.open = false; //make sure this starts false when the script runs
}
function onPlayerChats() {
if (player.chat == "/open" && clientr.staff == 1) {
this.open = true;
onCheck();
} else if (player.chat == "/close" && clientr.staff == 1) {
this.open = false;
onCheck();
}
}
function onCheck() {
if (this.open == true) {
this.image.show();
} else if (this.open == false) {
this.image.hide();
}
}
Also as Grief mentioned the
Is always your friend, reason being it looks cleaner and what can go wrong using less amount of code?PHP Code:if(..) {
} else if(...) {
}
Hope this helps and Good luck your doing great!
Thanks Noof!!
Staff Block image script
PHP Code://#CLIENTSIDE
function onPlayerChats () {
if (clientr.staff == 1 && player.chat == "/showblock") {
setimg (300, "block.png", player.x + 0.5, player.y + 0.5);
with ("300");
mode = 1;
red = 0;
green = 0;
blue = 1;
alpha = 0.4;
this.message = "Hi, I'm iMask";
}
}
Do not forget the client side my friend, and the code looks good besides that, can't complain.PHP Code://#CLIENTSIDE
Good Work.
Ahh, forgot it lolol! ThanksssQuote:
Originally Posted by Noofboy12
Hi, I found a few errors in you're last script.
Error 1: setimg (300, "block.png", player.x + 0.5, player.y + 0.5); You have a space between setimg and (300...) that will cause the script not to run.
Error 2: When ever you are adding something like player.x + 0.5, player.y + 0.5 make sure you are using the += either or -= in the code I will provide you with you will see the adjusments I made and I even stored it in a seperate variable for you!
Error 3: with ("300"); is wrong check out the code below of what should work.
Keep practicing and do NOT forget the clientside again ;)PHP Code://#CLIENTSIDE
function onCreated() {
temp.plx = player.x += 0.5; //Added this
temp.ply = player.y += 0.5; //Added this
if (this.block == "on") {
with(findimg(300)) { //the findimg should be used in this format :)
mode = 1;
red = 0; //Why have it if it is just setting to 0? :0
green = 0;
blue = 1;
alpha = 0.4;
this.message = "Hi, I'm iMask";
}
}
}
function onPlayerChats() {
if (clientr.staff == 1 && player.chat == "/showblock") {
setimg(300, "block.png", player.plx, player.ply);
this.block == "on";
onCreated();
}
}
-Noof
Why wouldn't it?Quote:
Originally Posted by Noofboy12
Quote:
** Small note:
you can name your functions and variables (I'll talk about that) whatever you want.
spaces do not matter, it's just for a nice coding style, so having:
Is the same as having :PHP Code:function onCreated() {
echo ("HIII");
echo("ELLO");
}
end of small note**PHP Code:function onCreated(){echo("HIII");echo("ELLO");}
Nope, player.x += 0.5 is adding 5 to player.x, and then assigning the value to player.x and temp.plx, this is not what we want, we need to add 0.5 to player.x and assign it to temp.plx only. That would be temp.plx = player.x + 0.5; Same goes for y.Quote:
Error 2: When ever you are adding something like player.x + 0.5, player.y + 0.5 make sure you are using the += either or -= in the code I will provide you with you will see the adjusments I made and I even stored it in a seperate variable for you!
Quote:
Error 3: with ("300"); is wrong check out the code below of what should work.
Keep practicing and do NOT forget the clientside again ;)PHP Code://#CLIENTSIDE
function onCreated() {
temp.plx = player.x + 0.5; //Added this
temp.ply = player.y + 0.5; //Added this
if (this.block == "on") {
with(findimg(300)) { //the findimg should be used in this format :)
mode = 1;
red = 0; //Why have it if it is just setting to 0? :0 // it's better if he keeps it here, trust me.
green = 0;
blue = 1;
alpha = 0.4;
this.message = "Hi, I'm iMask";
}
}
}
function onPlayerChats() {
if (clientr.staff == 1 && player.chat == "/showblock") {
setimg(300, "block.png", player.plx, player.ply);
this.block = "on"; // This is supposed to be = "on"; and better to use true/false
onCreated();
}
}
-Noof
Thanks guys!
I'm trying to create something where if you say /open (number here), the door would open for that many seconds.
If anyone could tell me what to put inside the sleep function and tell me if I'm doing it right, that would be great!PHP Code:function onCreated () {
setimg("door.png");
setshape (1,32,32);
}
//#CLIENTSIDE
function onPlayerChats () {
if (player.chat.starts == "/open" && clientr.staff == 1) {
this.time.open = player.chat.substring(6).trim();
this.show();
sleep(???); //see below
this.hide();
}
}
What's the point of making a variable if you're not going to use it?Quote:
Originally Posted by iMask
PHP Code://Put the " this.time.open" inside the sleep function.
function onCreated () {
setimg("door.png");
setshape (1,32,32);
}
//#CLIENTSIDE
function onPlayerChats () {
if (player.chat.starts == "/open" && clientr.staff == 1) {
this.timeOpen = player.chat.substring(6).trim();
this.show();
sleep(this.timeOpen); //see below
this.hide();
}
}
I was going to put the variable in the sleep function :)Quote:
Originally Posted by Grief Hero
Could have done then tested it out.Quote:
Originally Posted by iMask
Quote:
Originally Posted by iMask
That's a useless script.
We already have one to where you say any number and right click he door, it will open it.
1. It's called practiseQuote:
Originally Posted by AceLion
2. This is not for iEra
Script Continued
PHP Code:function onCreated () {
setimg("door.png");
setshape (1,32,32);
this.open = off;
}
//#CLIENTSIDE
function onPlayerChats () {
if (player.chat.starts == "/open" && clientr.staff == 1) {
this.timeOpen = player.chat.substring(6).trim();
this.show();
this.open = on;
this.chat = "Open for "@this.timeOpen@" seconds";
sleep(this.timeOpen);
this.hide();
this.open = off;
this.chat = "";
}
}
function onPlayerGrabs () {
if (this.open == "on") {
setlevel2 ("level_name.nw", 30, 30);
}
}
Hi, A few things to take into consideration.
Would be a string so it should bePHP Code:this.open = off;
And because you did not put the apostrophes to signal it is a string you can not use an if statement asking if it is certain string.PHP Code:this.open = "off";
Good job none the less, that is all I noticed from a first glance I'll check the whole thing another time!
Weird, because the code below is tested, and it works (tested on the testbed server)Quote:
Originally Posted by Noofboy12
Spawn Staff Blocks
IN THE CLASS:PHP Code://Coded by iMask
findplayer("id").addWeapon(name);
function onActionServerSide () {
putnpc2 (player.x + 0.5, player.y + 0.5, "join \"imask_block\");");
}
//#CLIENTSIDE
function onCreated () {
this.on = false;
}
function onPlayerChats () {
if (player.chat == "/block on") {
this.on = true;
player.chat = "On! Press 5 to spawn blocks!";
}
if (player.chat = "/block off") {
this.on = false;
player.chat = "Off!";
}
}
function onKeyPressed (code,key) {
if (this.on == true && temp.key == 5) {
player.chat = "Spawned! Slash to destroy!";
triggerserver ("gui", this.name, NULL);
}
}
PHP Code:function onCreated () {
setimg ("block.png");
setshape (1,32,32);
}
function onWa**** () { //function onWas-Hit, Era Go censored it
this.destroy();
}
Jail script
PHP Code://Coded by iMask
findplayer("id").addweapon(name);
function onActionServerSide () {
if (pl.account == player.jail) {
setlevel2 ("jail.nw", 30, 30);
}
}
//#CLIENTSIDE
function onPlayerChats () {
if (player.chat.starts == "/jail");
player.jail = player.chat.substring(5).trim();
triggerserver("gui", this.name, player.jail);
}
}
Since I have not updated this thread in ages, I'll post a fully functional lottery script. I still have to add a timer, but other than that, I'm happy with the results.
Lottery Script
PHP Code://Coded by iMask
function onPlayerLogin(temp.pl) {
temp.pl.addweapon(this.name);
}
function onActionServerSide(temp.cmd) {
switch(temp.cmd) {
case"one":
if (clientr.coins < 25) {
player.chat = "I don't have enough to buy a lottery ticket!";
return;
}
if (clientr.coins >= 25) {
clientr.coins -= 25;
this.jackpot += 20;
player.chat = "Bought one ticket! Coins: " @ clientr.coins;
this.winners.add(player.account);
}
break;
case"reset":
echo("Lottery: " @ player.account @ " has ended the lottery!");
sleep(5);
echo("Lottery: " @ this.winners.size() @ " tickets were sold");
this.winner = int(random(0,this.winners.size()));
sleep(5);
if (findplayer(this.winners[this.winner]) == NULL) {
temp.pl = new TServerPlayer(@this.winners[this.winner]);
temp.pl.clientr.coins += this.jackpot;
serverr.lastlotterywon = temp.pl.account;
echo("Lottery Winner: Offline player " @ temp.pl.account @ " ("@temp.pl.nick@") has won!");
temp.pl.saveaccount();
temp.pl.destroy();
} else {
player.chat = "I have won the lottery!";
clientr.coins += this.jackpot;
serverr.lastlotterywon = this.winners[this.winner];
echo("Lottery Winner: Online Winner " @ this.winners[this.winner] @ ". He won " @ this.jackpot @ " coins.");
}
player.chat = this.winners[this.winner] @ " has won!";
this.winners = {};
this.jackpot = 0;
echo("Lottery: Lottery reset!");
break;
case"onlotcheck":
player.chat = this.winners.size() @ " tickets have been sold";
break;
}
}
//#CLIENTSIDE
function onCreated() {
this.winners = {};
}
function onPlayerChats() {
if (player.chat == "/lottery") {
Buy_1.visible = true;
Close.visible = true;
Timer.visible = true;
showGui();
}
if (player.chat == "/endlottery" && player.account == "Graal762515") {
triggerserver("gui",this.name,"reset");
}
if (player.chat == "/showlottery" && clientr.isStaff) {
triggerserver("gui",this.name,"onlotcheck");
}
}
function showGui() {
new GuiButtonCtrl("Buy_1") {
profile = GuiBlueButtonProfile;
x = 600;
y = 200;
width = 250;
height = 30;
text = "Buy lottery ticket (25 coins for 1 ticket)";
}
new GuiButtonCtrl("Close") {
profile = GuiBlueButtonProfile;
x = 600;
y = 230;
width = 250;
height = 30;
text = "Close";
}
new GuiTextCtrl("Timer") {
profile = GuiBlueTextProfile;
x = 1150;
y = 220;
text = this.timer;
}
}
function Buy_1.onAction() {
triggerserver("gui",this.name,"one");
}
function Close.onAction() {
Buy_1.visible = false;
Close.visible = false;
Timer.visible = false;
}
Scripts look so complicated and confusing.
Scripting in general can look very intimidating, this is why not many people take the challenge to learn. For a beginner these scripts can look confusing and long.Quote:
Originally Posted by Pumpkins
If you learn and you get to a good level, this will all make sense.
:)
^^^ agreed.Quote:
Originally Posted by Noofboy12